| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Oddity in tuple routing for foreign partitions |
| Date: | 2018-04-25 01:17:02 |
| Message-ID: | f894af29-345f-678b-480a-9f6e8cc314bd@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018/04/25 4:49, Robert Haas wrote:
> On Tue, Apr 24, 2018 at 12:21 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Mon, Apr 23, 2018 at 11:25 AM, Alvaro Herrera
>> <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>>> Robert, I think this is your turf, per 3d956d9562aa. Are you looking
>>> into it?
>>
>> Thanks for the ping. I just had a look over the proposed patch and I
>> guess I don't like it very much. Temporarily modifying the range
>> table in place and then changing it back before we return seems ugly
>> and error-prone. I hope we can come up with a solution that doesn't
>> involve needing to do that.
>
> I have done some refactoring to avoid that. See attached.
+1 for getting rid of the PlannerInfo argument of the many functions in
that code. I have long wondered if we couldn't rid of it and especially
thought of it when reviewing this patch.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2018-04-25 01:37:51 | Re: Oddity in tuple routing for foreign partitions |
| Previous Message | Kyotaro HORIGUCHI | 2018-04-25 01:15:02 | Re: Oddity in tuple routing for foreign partitions |