Re: Exclude schema during pg_restore

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Banck <mbanck(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Exclude schema during pg_restore
Date: 2016-09-02 01:39:56
Message-ID: f8948108-4a72-fe46-97b5-fba7b13d72f7@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 8/31/16 4:10 AM, Michael Banck wrote:
> attached is a small patch that adds an -N option to pg_restore, in order
> to exclude a schema, in addition to -n for the restriction to a schema.

I think this is a good idea, and the approach looks sound. However,
something doesn't work right. If I take an empty database and dump it,
it will dump the plpgsql extension. If I run pg_dump in plain-text mode
with -N, then the plpgsql extension is also dumped (since it is not in
the excluded schema). But if I use the new pg_restore -N option, the
plpgsql extension is not dumped. Maybe this is because it doesn't have
a schema, but I haven't checked.

pg_dump does not apply --strict-names to -N, but your patch for
pg_restore does that. I think that should be made the same as pg_dump.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2016-09-02 02:20:24 Re: [PATCH] COPY vs \copy HINT
Previous Message Jeff Janes 2016-09-02 01:01:21 Re: restoration after crash slowness, any way to improve?