| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | pgsql-docs(at)lists(dot)postgresql(dot)org |
| Subject: | Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs |
| Date: | 2025-06-18 05:34:55 |
| Message-ID: | f86cd84f-a6a3-4451-bae7-5cca9e63b06d@oss.nttdata.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
Hi,
Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE.
In this feature, since indexes are not created for foreign tables,
comments on indexes are not copied either.
However, the CREATE FOREIGN TABLE docs incorrectly states that
index comments are copied when using INCLUDING COMMENTS, as shown below:
------------------------------
INCLUDING COMMENTS
Comments for the copied columns, constraints, and indexes will be copied.
------------------------------
This isn't accurate for foreign tables, so we should remove the mention
of indexes. Patch attached.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-doc-Fix-incorrect-description-of-INCLUDING-COMMEN.patch | text/plain | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-06-18 06:50:23 | Re: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs |
| Previous Message | Fujii Masao | 2025-06-18 00:21:18 | Re: Reorder min/max_protocol_version descriptions in libpq documentation |