| From: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Greg Stark <stark(at)mit(dot)edu> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> |
| Subject: | Re: JSON constructors and window functions |
| Date: | 2022-05-10 13:51:38 |
| Message-ID: | f827b327-2f78-f20b-b095-59461389a3bb@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 4/4/22 2:19 PM, Andrew Dunstan wrote:
>
> On 4/4/22 12:33, Andres Freund wrote:
> It can, as Jaime's original post showed.
>
> But on further consideration I'm thinking this area needs some rework.
> ISTM that it might be a whole lot simpler and comprehensible to generate
> the json first without bothering about null values or duplicate keys and
> then in the finalizer check for null values to be skipped and duplicate
> keys. That way we would need to keep far less state for the aggregation
> functions, although it might be marginally less efficient. Thoughts?
This is still on the open items list[1]. Given this is a
user-triggerable crash and we are approaching PG15 Beta 1, I wanted to
check in and see if there was any additional work required to eliminate
the crash, or if the work at this point is just optimization.
If the latter, I'd suggest we open up a new open item for it.
Thanks,
Jonathan
[1] https://wiki.postgresql.org/wiki/PostgreSQL_15_Open_Items
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2022-05-10 13:55:18 | Re: Column Filtering in Logical Replication |
| Previous Message | Ashutosh Bapat | 2022-05-10 13:47:35 | Re: Allowing REINDEX to have an optional name |