| From: | Jacob Champion <pchampion(at)vmware(dot)com> |
|---|---|
| To: | "horikyota(dot)ntt(at)gmail(dot)com" <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Accept IP addresses in server certificate SANs |
| Date: | 2022-01-06 00:02:27 |
| Message-ID: | f7d53c77e33b2e22e520f2b3aac7c5b863636b85.camel@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2022-01-03 at 16:19 +0000, Jacob Champion wrote:
> On Fri, 2021-12-17 at 15:40 +0900, Kyotaro Horiguchi wrote:
> >
> > + inet_net_pton_ipv4(const char *src, u_char *dst)
> > (calls inet_net_pton_ipv4_internal(src, dst, true))
> > + inet_pton_ipv4(const char *src, u_char *dst)
> > (calls inet_net_pton_ipv4_internal(src, dst, false))
>
> Sounds good, I will make that change. Thanks for the feedback!
v3 implements a pg_inet_pton(), but for IPv6 instead of IPv4 as
presented above (since we only need inet_pton() for IPv6 in this case).
It's split into a separate patch (0003) for ease of review.
Thanks!
--Jacob
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Move-inet_net_pton-to-src-port.patch | text/x-patch | 4.5 KB |
| v3-0002-libpq-allow-IP-address-SANs-in-server-certs.patch | text/x-patch | 38.2 KB |
| v3-0003-squash-libpq-allow-IP-address-SANs-in-server-cert.patch | text/x-patch | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2022-01-06 00:03:55 | Re: Add 64-bit XIDs into PostgreSQL 15 |
| Previous Message | Bruce Momjian | 2022-01-06 00:02:16 | Re: Add 64-bit XIDs into PostgreSQL 15 |