Re: Define jsonpath functions as stable

From: Erik Rijkers <er(at)xs4all(dot)nl>
To: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Chapman Flack <chap(at)anastigmatix(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Define jsonpath functions as stable
Date: 2019-09-17 16:09:01
Message-ID: f7d13fa3bfe17e0d6c0160501bed1117@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-09-17 17:38, Jonathan S. Katz wrote:
> On 9/16/19 6:39 PM, Jonathan S. Katz wrote:
> [regex.patch]

A few things/typos caught my eye:

1.
'implementation' seems the wrong word in sentence:

"Several other parts of the SQL standard
also define LIKE_REGEX equivalents that refer
to this implementation, including the
SQL/JSON path like_regex filter."

As I understand this text, 'concept' seems better.
I'd drop 'also', too.

2.
'whereas the POSIX will those' should be
'whereas POSIX will regard those'
or maybe 'read those'

3.
+ The SQL/JSON standard borrows its definition for how regular
expressions
+ from the <literal>LIKE_REGEX</literal> operator, which in turns
uses the
+ XQuery standard.
That sentence needs the verb 'work', no? 'for how regular expressions
work [..]'
Or alternatively drop 'how'.

thanks,

Erik Rijkers

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2019-09-17 16:09:08 Re: block-level incremental backup
Previous Message Marina Polyakova 2019-09-17 16:07:31 pg_upgrade check fails on Solaris 10