| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PGPROC alignment (was Re: pgsql: Separate RecoveryConflictReasons from procsignals) |
| Date: | 2026-02-20 21:01:33 |
| Message-ID: | f7bd155e-0bd4-4b09-86b3-92140af98654@iki.fi |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 11/02/2026 06:40, Bertrand Drouvot wrote:
> On Tue, Feb 10, 2026 at 10:53:58PM +0200, Heikki Linnakangas wrote:
> 0003:
>
> 1/ There is one missing change in PrintLockQueue() ("links" is still used, and
> that should be replaced by "waitLink").
>
> 2/ change the comment on top of ProcWakeup?
>
> "
> /*
> * ProcWakeup -- wake up a process by setting its latch.
> *
> * Also remove the process from the wait queue and set its links invalid.
> "
>
> s/links/waitLink/?
Fixed those and pushed this "Split PGPROC 'links' field into two, for
clarity" patch. Thanks for the review!
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-02-20 21:03:09 | Re: PGPROC alignment (was Re: pgsql: Separate RecoveryConflictReasons from procsignals) |
| Previous Message | Heikki Linnakangas | 2026-02-20 21:01:18 | pgsql: Split PGPROC 'links' field into two, for clarity |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-02-20 21:03:09 | Re: PGPROC alignment (was Re: pgsql: Separate RecoveryConflictReasons from procsignals) |
| Previous Message | Harinath Kanchu | 2026-02-20 20:57:35 | Re: Streaming replication and WAL archive interactions |