| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | emre(at)hasegeli(dot)com |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve geometric types |
| Date: | 2018-08-17 18:48:49 |
| Message-ID: | f7a207c9-b756-11b5-cada-9a59dffe6dd1@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08/17/2018 08:24 PM, Emre Hasegeli wrote:
>> BTW how did we end up with the regression differences? Presumably you've
>> tried that on your machine and it passed. So if we adjust the expected
>> file, won't it fail on some other machines?
>
> I had another patch to check for -0 inside float{4,8}_{div,mul}(). I
> dropped it on the last set of patches, so the tests were broken. I
> get -0 as a result of -x * 0 both on Mac and Linux.
>
OK, that explains is. I won't have time to get this committed before CF
2018-09, but I'll pick it up in September.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-08-17 18:55:03 | Re: [HACKERS] WIP: long transactions on hot standby feedback replica / proof of concept |
| Previous Message | Tom Lane | 2018-08-17 18:32:59 | Performance improvements for src/port/snprintf.c |