| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, "Masashi Kamura (Fujitsu)" <kamura(dot)masashi(at)fujitsu(dot)com> |
| Cc: | "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jeff Davis <pgsql(at)j-davis(dot)com> |
| Subject: | Re: Crash issue in PG18.5 regression |
| Date: | 2026-08-11 09:41:49 |
| Message-ID: | f72a8fbe-7ef1-4cd3-8a4b-fd9106480510@iki.fi |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/08/2026 12:19, Heikki Linnakangas wrote:
> I think the best fix is to make pg_strupper() in REL_18_STABLE also work
> with the C locale. It's an accident waiting to happen if it doesn't.
> (And same for all the other pg_str*() functions, of course)
Like the attached.
There's some code duplication: the strupper_c() function is essentially
the same as asc_toupper(), and str_toupper() wouldn't really need to
have the special case for C locale anymore, it could just rely on
pg_strupper() now. But that's so in 'master' too, so I think cleaning
that up should be left for a separate patch.
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-pg_strupper-lower-fold-functions-work-with-C-loc.patch | text/x-patch | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikhil Sontakke | 2026-08-11 10:12:46 | Stale comments for the tuple_update/tuple_delete options parameter |
| Previous Message | Yilin Zhang | 2026-08-11 09:21:03 | Re: Per-table resync for logical replication subscriptions |