Re: pgsql: Fix typo in documentation of toast storage

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix typo in documentation of toast storage
Date: 2018-11-26 07:36:50
Message-ID: f69567fd-4a9d-79f1-1a31-1483d407f900@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2018/11/26 16:16, Vik Fearing wrote:
> On 26/11/2018 07:55, Michael Paquier wrote:
>> Fix typo in documentation of toast storage
>>
>> Author: Nawaz Ahmed
>> Discussion: https://postgr.es/m/154319327168.1315.1846953598601966513@wrigleys.postgresql.org
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> https://git.postgresql.org/pg/commitdiff/058ef3a1a8469bbaae6b0e6647cd031b9ca71b2d
>>
>> Modified Files
>> --------------
>> doc/src/sgml/storage.sgml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I don't think this is a correct change? I guess I'll go see the
> discussion thread, but this looks wrong to me.

Seems that way to me too.

A table that has columns with potentially large entries will have an
associated <firstterm>TOAST</firstterm> table, which is used for
out-of-line storage of
-field values that are too large to keep in the table rows proper.
+field values that are too large to keep in the table rows properly.

I think "in the table rows proper" means something like "in the table rows
themselves", although a native speaker can clarify it better. A bit of
Internet searching tells that "proper" used like this is a "post-positive
adjective"

https://english.stackexchange.com/questions/354077/use-of-proper-as-a-postpositive-adjective

Thanks,
Amit

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-11-26 07:46:13 pgsql: Revert "Fix typo in documentation of toast storage"
Previous Message Vik Fearing 2018-11-26 07:16:10 Re: pgsql: Fix typo in documentation of toast storage