Re: pgsql: SQL-standard function body

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: SQL-standard function body
Date: 2021-04-16 10:26:16
Message-ID: f6852374-022c-29ec-4828-ae2c8a4e4668@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 12.04.21 21:00, Laurenz Albe wrote:
>>> Here is an improved patch, which treats END in the same fashion
>>> (not properly indented for readability).
>>
>> Thanks, I took another look at this and augmented your change with a
>> change that tracks whether the statement starts with CREATE [OR REPLACE]
>> {FUNCTION|PROCEDURE}. That should make it pretty safe. What do you think?
>
> Thanks, that is fine with me and more than I asked for.
> That should definitely exclude all false positive matches.

committed

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-04-16 12:46:52 Re: pgsql: Use SIGURG rather than SIGUSR1 for latches.
Previous Message Peter Eisentraut 2021-04-16 10:24:40 pgsql: psql: Refine lexing of BEGIN...END blocks in CREATE FUNCTION sta