| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Rémi Lapeyre <remi(dot)lapeyre(at)lenstra(dot)fr> |
| Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Daniel Verite <daniel(at)manitou-mail(dot)org> |
| Subject: | Re: Add header support to text format and matching feature |
| Date: | 2022-01-31 06:54:01 |
| Message-ID: | f62f0262-2a3c-8839-5ced-25ca2421d738@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 30.01.22 23:56, Rémi Lapeyre wrote:
>> I notice in the 0002 patch that there is no test case for the error "wrong header for column \"%s\": got \"%s\"", which I think is really the core functionality of this patch. So please add that.
>>
>
> I added a test for it in this new version of the patch.
The file_fdw.sql tests contain this
+CREATE FOREIGN TABLE header_doesnt_match (a int, foo text) SERVER
file_server
+OPTIONS (format 'csv', filename :'filename', delimiter ',', header
'match'); -- ERROR
but no actual error is generated. Please review the additions on the
file_fdw tests to see that they make sense.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2022-01-31 07:04:52 | Re: Error "initial slot snapshot too large" in create replication slot |
| Previous Message | Kyotaro Horiguchi | 2022-01-31 06:20:11 | Re: Error "initial slot snapshot too large" in create replication slot |