Re: psql: Add role's membership options to the \du+ command

From: Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: David Zhang <david(dot)zhang(at)highgo(dot)ca>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql: Add role's membership options to the \du+ command
Date: 2023-03-20 08:49:55
Message-ID: f60046e7-b42f-6418-12d3-3c107c1e5cef@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10.03.2023 15:06, Pavel Luzanov wrote:
> I missed the comment at the beginning of the file about version 9.2. I
> will return the version check for rolbypassrls.

>> +        <para>
>> +        Shown within each row, in newline-separated format, are the
>> memberships granted to
>> +        the role.  The presentation includes both the name of the
>> grantor
>> +        as well as the membership permissions (in an abbreviated format:
>> +        <literal>a</literal> for admin option, <literal>i</literal>
>> for inherit option,
>> +        <literal>s</literal> for set option.) The word
>> <literal>empty</literal> is printed in
>> +        the case that none of those permissions are granted.
>> +        See the <link
>> linkend="sql-grant"><command>GRANT</command></link> command for their
>> meaning.
>> +        </para>
>> +        <para>
>> +        If the form <literal>\dg+</literal> is used the comment
>> attached to the role is shown.
>>          </para>
>
> Thanks. I will replace the description with this one.

>
>> I would suggest tweaking the test output to include regress_du_admin
>> and also to make regress_du_admin a CREATEROLE role with LOGIN.
>
> Ok.

Please review the attached version 4 with the changes discussed.

-----
Pavel Luzanov

Attachment Content-Type Size
v4-0001-psql-show-membership-options-in-the-du-command.patch text/x-patch 13.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-03-20 08:53:48 Re: Data is copied twice when specifying both child and parent table in publication
Previous Message Tomas Vondra 2023-03-20 08:32:17 Re: Memory leak from ExecutorState context?