| From: | Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Alex Kozhemyakin <a(dot)kozhemyakin(at)postgrespro(dot)ru> |
| Subject: | Re: Bug in DefineRange() with multiranges |
| Date: | 2021-10-12 05:52:29 |
| Message-ID: | f50a7e90-b166-b41d-3a7d-c0344974446e@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10.10.2021 20:12, Peter Eisentraut wrote:
> On 04.10.21 19:09, Sergey Shinderuk wrote:
>> I wonder what is the proper fix. Just drop pfree() altogether or add
>> pstrdup() instead? I see that makeMultirangeTypeName() doesn't bother
>> freeing its buf.
>
> I think removing the pfree()s is a correct fix.
>
Thanks, here is a patch.
--
Sergey Shinderuk https://postgrespro.com/
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-premature-pfree-of-multirange_type_name-in-Defin.patch | text/plain | 991 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2021-10-12 06:00:43 | Re: Error "initial slot snapshot too large" in create replication slot |
| Previous Message | Ants Aasma | 2021-10-12 05:40:17 | Re: storing an explicit nonce |