Re: pgsql: Add 'basebackup_to_shell' contrib module.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: 2022-03-31 14:51:53
Message-ID: f48f62be-56fb-7c0b-7d09-a617b5c6e64a@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 3/30/22 22:07, Tom Lane wrote:
> So ... none of the Windows buildfarm members actually like this
> test script. They're all showing failures along the lines of
>
> not ok 2 - fails if basebackup_to_shell.command is not set: matches
>
> # Failed test 'fails if basebackup_to_shell.command is not set: matches'
> # at t/001_basic.pl line 38.
> # 'pg_basebackup: error: connection to server at "127.0.0.1", port 55358 failed: FATAL: SSPI authentication failed for user "backupuser"
> # '
> # doesn't match '(?^:shell command for backup is not configured)'
>
> Does the CI setup not account for this issue?
>
>

I have configured fairywren and drongo to use Unix sockets., and they
have turned green Here are the settings I'm using in the config's
build_env section:

                PG_TEST_USE_UNIX_SOCKETS => 1,
                PG_REGRESS_SOCK_DIR =>
'C:/Users/pgrunner/AppData/Local/Temp',

We should probably fix the test though, so it doesn't require Unix
sockets. It should be possible, although I haven't looked yet to see how.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2022-03-31 15:12:07 Re: pgsql: Add 'basebackup_to_shell' contrib module.
Previous Message Peter Eisentraut 2022-03-31 14:33:18 pgsql: psql: Add tests for \errverbose

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias van de Meent 2022-03-31 14:58:15 Re: Restructure ALTER TABLE notes to clarify table rewrites and verification scans
Previous Message James Coleman 2022-03-31 14:51:28 Re: Correct docs re: rewriting indexes when table rewrite is skipped