Re: Patch to avoid orphaned dependencies

From: "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gilles Darold <gilles(at)darold(dot)net>, "Nasby, Jim" <nasbyj(at)amazon(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: Patch to avoid orphaned dependencies
Date: 2022-01-04 09:28:27
Message-ID: f4590f3b-a4b6-8b4b-37a1-d7ffe8bd58c2@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 12/31/21 7:03 AM, Andres Freund wrote:
> Hi,
>
> On 2021-12-17 14:19:18 +0100, Drouvot, Bertrand wrote:
>> Please find enclosed v1-0003-orphaned-dependencies.patch, that contains:
>>
>> - a mandatory rebase
>>
>> - a few isolation tests added in src/test/modules/test_dependencies (but I'm
>> not sure at all that's the right place to add them, is it?)
> This fails on windows w/ msvc:
>
> https://cirrus-ci.com/task/5368174125252608?logs=configure#L102
> https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.157904#L12

Thanks Andres for the warning.

Please find enclosed v1-0004-orphaned-dependencies.patch that addresses
the issue.

Thanks

Bertrand

Attachment Content-Type Size
v1-0004-orphaned-dependencies.patch text/plain 31.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2022-01-04 09:55:06 Re: SQL/JSON: functions
Previous Message Himanshu Upadhyaya 2022-01-04 09:18:33 Re: SQL/JSON: functions