Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

From: David Steele <david(at)pgmasters(dot)net>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Chapman Flack <chap(at)anastigmatix(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
Date: 2022-04-05 16:06:08
Message-ID: f3effc63-2d2d-59f5-3c87-7239b7c225bb@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/5/22 11:25 AM, Stephen Frost wrote:
>
> Please find attached an updated patch + commit message. Mostly, I just
> went through and did a bit more in terms of updating the documentation
> and improving the comments (there were some places that were still
> worrying about the chance of a 'stray' backup_label file existing, which
> isn't possible any longer), along with some additional testing and
> review. This is looking pretty good to me, but other thoughts are
> certainly welcome. Otherwise, I'm hoping to commit this tomorrow.

I have reviewed the changes and they look good. I also ran the new patch
through pgbackrest regression with no issues.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-04-05 16:17:04 Re: [PATCH] pg_stat_toast v10
Previous Message Bharath Rupireddy 2022-04-05 15:53:24 How to simulate sync/async standbys being closer/farther (network distance) to primary in core postgres?