Remove configure --disable-float4-byval and --disable-float8-byval

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Remove configure --disable-float4-byval and --disable-float8-byval
Date: 2019-10-31 08:50:16
Message-ID: f3e1e576-2749-bbd7-2d57-3f9dcf75255a@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

AFAICT, these build options were only useful to maintain compatibility
for version-0 functions, but those are no longer supported, so these
options can be removed. There is a fair amount of code all over the
place to support these options, so the cleanup is quite significant.

The current behavior became the default in PG9.3. Note that this does
not affect on-disk storage. The only upgrade issue that I can see is
that pg_upgrade refuses to upgrade incompatible clusters if you have
contrib/isn installed. But hopefully everyone who is affected by that
will have upgraded at least once since PG9.2 already.

float4 is now always pass-by-value; the pass-by-reference code path is
completely removed.

float8 and related types are now hardcoded to pass-by-value or
pass-by-reference depending on whether the build is 64- or 32-bit, as
was previously also the default.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Remove-configure-disable-float4-byval-and-disable-fl.patch text/plain 31.3 KB
0002-Replace-USE_FLOAT8_BYVAL-by-FLOAT8PASSBYVAL.patch text/plain 8.2 KB
0003-Convert-some-if-calls-to-compiler-if-s.patch text/plain 5.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-10-31 08:55:55 Re: [PATCH] Do not use StdRdOptions in Access Methods
Previous Message Antonin Houska 2019-10-31 08:43:47 Re: MarkBufferDirtyHint() and LSN update