Re: Remove configure --disable-float4-byval and --disable-float8-byval

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> float4 is now always pass-by-value; the pass-by-reference code path is
> completely removed.

I think this is OK.

> float8 and related types are now hardcoded to pass-by-value or
> pass-by-reference depending on whether the build is 64- or 32-bit, as
> was previously also the default.

I'm less happy with doing this. It makes it impossible to test the
pass-by-reference code paths without actually firing up a 32-bit
environment. It'd be fine to document --disable-float8-byval as
a developer-only option (it might be so already), but I don't want
to lose it completely. I fail to see any advantage in getting rid
of it, anyway, since we do still have to maintain both code paths.

regards, tom lane