| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add function to import operating system collations |
| Date: | 2017-01-19 21:20:27 |
| Message-ID: | f34dbd10-932b-eabf-86c6-eb692d0bfc57@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 1/19/17 11:58 AM, Tom Lane wrote:
> Stephen Frost <sfrost(at)snowman(dot)net> writes:
>> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>>> WFM. Btw, I noticed that BOOTSTRAP_SUPERUSERID is hard-coded as "10"
>>> in this bit in setup_privileges():
>
>> Hm. I seem to recall trying to avoid having the hard-coded value there
>> but we don't have BOOTSTRAP_SUPERUSERID defined somewhere that initdb.c
>> could include it from, do we? It's only in catalog/pg_authid.h.
>
> Looks to me like including catalog/pg_authid.h in initdb would work fine.
> pg_upgrade does it.
I have fixed that together with Amit's issue.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-01-19 21:24:47 | pgsql: Fix race condition in reading commit timestamps |
| Previous Message | Peter Eisentraut | 2017-01-19 21:19:09 | pgsql: initdb: Fix for mixed-case superuser names |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Seltenreich | 2017-01-19 21:20:33 | Re: Improving RLS planning |
| Previous Message | Kevin Grittner | 2017-01-19 21:19:39 | Re: delta relations in AFTER triggers |