| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Remove IS_AF_UNIX macro? |
| Date: | 2022-02-07 07:48:50 |
| Message-ID: | f2d26815-9832-e333-d52d-72fbc0ade896@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I noticed that in pgstatfuncs.c, the AF_UNIX macro is being used
unprotected by HAVE_UNIX_SOCKETS, apparently since 2008. So I think the
redirection through IS_AF_UNIX() is no longer necessary. (More
generally, all supported platforms are now HAVE_UNIX_SOCKETS, but even
if there were a new platform in the future, it seems plausible that it
would define the AF_UNIX symbol even without kernel support.) So maybe
we should remove the IS_AF_UNIX() macro and make the code a bit more
consistent?
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-IS_AF_UNIX-macro.patch | text/plain | 8.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2022-02-07 07:50:37 | Re: row filtering for logical replication |
| Previous Message | Dilip Kumar | 2022-02-07 07:24:56 | Re: decoupling table and index vacuum |