| From: | Alexey Makhmutov <a(dot)makhmutov(at)postgrespro(dot)ru> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Standby server with cascade logical replication could not be properly stopped under load |
| Date: | 2025-05-22 18:22:02 |
| Message-ID: | f2575904-acfe-4037-9748-61fdb4a7abe4@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi Bertrand, thank you for looking at this issue.
On 5/22/25 18:31, Bertrand Drouvot wrote:
> I agree with your analysis and I think that your proposed fix make sense. I
> wonder if the comment on top of GetStandbyFlushRecPtr() could be updated a bit
> though.
I've tried to update method comment as well in the updated patch:
0001-Use-only-replayed-position-as-target-flush-point-3-pg-master.patch.
The same patch could be applied on top of PG 17 as well.
PG 16 does not have the slot synchronization logic, so its
implementation of GetStandbyFlushRecPtr is slightly different and
comments need to be updated to reflect this discrepancy as well. So,
here is a variant of the same patch updated to be compatible with PG 16:
0002-Use-only-replayed-position-as-target-flush-point-3-pg-16.patch
Thanks,
Alexey
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Use-only-replayed-position-as-target-flush-point-3-pg-master.patch | text/x-patch | 4.0 KB |
| 0002-Use-only-replayed-position-as-target-flush-point-3-pg-16.patch | text/x-patch | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2025-05-22 21:18:44 | SIMILAR TO expressions translate wildcards where they shouldn't |
| Previous Message | Tom Lane | 2025-05-22 17:58:33 | Re: GSS Auth issue when user member of lots of AD groups |