| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Matheus Alcantara <mths(dot)dev(at)pm(dot)me>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns |
| Date: | 2022-11-01 11:20:54 |
| Message-ID: | f242cb2a-66d2-1ac2-d76e-1638ec9cc26d@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 26.10.22 00:45, Matheus Alcantara wrote:
>> I noticed that psql has no tab completion around identity columns in
>> ALTER TABLE, so here's some patches for that.
>>
>> In passing, I also added completion for ALTER SEQUECNE … START, which was
>> missing for some reason.
> I've tested all 4 of your patches, and all of them seem to work as expected.
>
> This is my first time reviewing a patch, so let's see if more experience
> hackers has anything more to say about these patches, but at first they
> seem correct to me.
This was sensible for a first review. Thanks for you help.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-11-01 11:28:46 | Add palloc_aligned() to allow arbitrary power of 2 memory alignment |
| Previous Message | Peter Eisentraut | 2022-11-01 11:19:54 | Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns |