Re: More test/kerberos tweaks

From: Jacob Champion <pchampion(at)vmware(dot)com>
To: "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "andrew(at)dunslane(dot)net" <andrew(at)dunslane(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: More test/kerberos tweaks
Date: 2021-02-05 21:54:58
Message-ID: f1fd9ccaf7ffb2327bf3c06120afeadd50c1db97.camel@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 2021-02-05 at 15:55 -0500, Tom Lane wrote:
> We have, almost invariably, regretted it when we tried to use short
> timeouts in test cases.

That's what I was afraid of. I can work around it easily enough on my
local machine, so it's not really a blocker in any sense.

That just leaves the first patch, then.

> On the whole, I think the right thing to be doing here is not so
> much messing with the timeout as fixing the test script to be
> more robust against control-C. If it's failing to shut down the
> KDC, I'd say that's a test bug.

Agreed. I'm trying to limit the amount of test churn I introduce, since
I don't speak Perl very well. :D

Reworking the log checks so that they didn't need timeouts (e.g. by
stopping the server or otherwise flushing the logs, a la the
ssl_passphrase_callback tests) would be another approach. I'll jot it
down to look into later.

--Jacob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2021-02-05 22:21:22 Re: Key management with tests
Previous Message Tom Lane 2021-02-05 21:53:44 Re: making update/delete of inheritance trees scale better