Re: No parameter values checking while creating Alter subscription...Connection

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: No parameter values checking while creating Alter subscription...Connection
Date: 2017-05-25 21:08:57
Message-ID: f1dd832d-a29f-f5aa-71bc-e8a24b005a57@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5/25/17 10:18, Masahiko Sawada wrote:
>> postgres=# alter subscription c1 connection 'port=4000';
>> ALTER SUBSCRIPTION
>> postgres=# alter subscription c1 connection 'dbname=cc';
>> ALTER SUBSCRIPTION
>>
> CREATE SUBSCRIPTION tries to connect to publisher to create
> replication slot or to get table list for table synchronization, not
> to check the connection parameter value. So if you specify connect =
> false then CREATE SUBSCRIPTION doesn't try to connect.

We don't make a connection attempt as part of ALTER SUBSCRIPTION. I
guess we could just connect and disconnect to check that it works.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-05-25 21:17:39 Channel binding support for SCRAM-SHA-256
Previous Message Peter Eisentraut 2017-05-25 21:06:45 Re: pg_dump ignoring information_schema tables which used in Create Publication.