Re: multi-install PostgresNode

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: multi-install PostgresNode
Date: 2021-03-24 14:58:06
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 3/24/21 9:23 AM, Andrew Dunstan wrote:
> On 3/24/21 8:29 AM, Alvaro Herrera wrote:
>> On 2021-Mar-24, Dagfinn Ilmari Mannsåker wrote:
>>> I think it would be even neater having a method that returns the desired
>>> environment and then have the other methods do:
>>> local %ENV = $self->_get_install_env();
>> Hmm, is it possible to integrate PGHOST and PGPORT handling into this
>> too? Seems like it is, so the name of the routine should be something
>> more general (and also it should not have the quick "return unless
>> $inst").
> If we're going to do that we probably shouldn't special case any
> particular settings, but simply take any extra arguments as extra env
> settings. And if any setting has undef (e.g. PGAPPNAME) we should unset it.

like this.



Andrew Dunstan

Attachment Content-Type Size
PostgresNodePath-5.patch text/x-patch 10.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-03-24 15:11:35 Re: [HACKERS] Custom compression methods
Previous Message Robert Haas 2021-03-24 14:50:50 Re: pgsql: Move tablespace path re-creation from the makefiles to pg_regres