| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Geoghegan <pg(at)bowt(dot)ie>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: check_strxfrm_bug() |
| Date: | 2023-04-20 15:10:54 |
| Message-ID: | f18b6ae181d785549c2547f05862ab96d9af857a.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 2023-04-20 at 13:34 +1200, Thomas Munro wrote:
> I could write a patch to remove the libc strxfrm support, but since
> Jeff recently wrote new code in 16 to abstract that stuff, he might
> prefer to look at it?
+1 to removing it.
As far as how it's removed, we could directly check:
if (!collate_c && !(locale && locale->provider == COLLPROVIDER_ICU))
abbreviate = false;
as it was before, or we could still try to hide it as a detail behind a
function. I don't have a strong opinion there, though I thought it
might be good for varlena.c to not know those internal details.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-04-20 15:33:38 | Re: LLVM strip -x fails |
| Previous Message | Andres Freund | 2023-04-20 15:06:52 | Re: pgsql: Further cleanup of autoconf output files for GSSAPI changes. |