| From: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Gunnar Morling <gunnar(dot)morling(at)googlemail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Unexpected behavior when setting "idle_replication_slot_timeout" |
| Date: | 2025-07-08 16:53:25 |
| Message-ID: | f12271e6aea3b87eaa430d0c9008ca1f3154c31e.camel@cybertec.at |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Sat, 2025-07-05 at 12:13 -0400, Tom Lane wrote:
> Oh, wait a second. I just noticed that this variable is new in v18.
> So there won't be a compatibility issue as long as we change it in
> v18 too. So changing it to a base of seconds seems sufficient,
> and more in line with existing practice:
>
> Using 'ms' seems clearly overkill, but there's precedent for
> timeouts measured in seconds.
Here is a patch that changes the unit to seconds, like Fujii Masao's
patch upthread. In addition, it removes the now unnecessary injection
point for the TAP test and tries to improve the documentation to
address my complaints.
Yours,
Laurenz Albe
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Change-idle_replication_slot_timeout-unit-to-seco.patch | text/x-patch | 10.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2025-07-08 17:34:23 | Re: BUG #18965: Issue with Short-Circuit Evaluation in Boolean Expressions |
| Previous Message | Tom Lane | 2025-07-08 16:51:56 | Re: BUG #18981: Fault tolerance and improvement for xmltotext_with_options (xml.c) |