Re: [PATCH] session_replication_role = replica with TRUNCATE

From: Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] session_replication_role = replica with TRUNCATE
Date: 2018-01-23 12:34:11
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Il 22/01/18 19:41, Petr Jelinek ha scritto:
> On 19/01/18 12:41, Marco Nenciarini wrote:
>> Hi Peter,
>> Il 18/01/18 17:30, Peter Eisentraut ha scritto:
>>> On 1/17/18 11:33, Petr Jelinek wrote:
>>>>> P.S: I'm struggling to understand why we have two possible values of
>>>>> session_replication_role settings that behave identically (origin and
>>>>> local). I'm unable to see any difference according to the code or the
>>>>> documentation, so I'm wondering if we should document that they are the
>>>>> same.
>>>> It's for use by 3rd party tools (afaik both londiste and slony use it)
>>>> to differentiate between replicated and not replicated changes.
>>> I have committed some documentation updates and tests to cover this a
>>> bit better.
>> Thanks, the documentation is a lot clearer now.
>> This superseded the documentation change that was in the patch, so I've
>> removed it from the v3 version.
> Now that we have tests for this, I think it would be good idea to expand
> them to cover the new behavior of TRUNCATE in this patch.

You are right. Attached the new v4 version.


Marco Nenciarini - 2ndQuadrant Italy
PostgreSQL Training, Services and Support
marco(dot)nenciarini(at)2ndQuadrant(dot)it |

Attachment Content-Type Size
0001-truncate_ignore_fks_role_replica.v4.patch text/plain 2.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Ildus Kurbangaliev 2018-01-23 13:04:54 Re: [HACKERS] Custom compression methods
Previous Message Abinaya k 2018-01-23 12:10:22 Regarding ambulkdelete, amvacuumcleanup index methods