From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
---|---|
To: | Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] session_replication_role = replica with TRUNCATE |
Date: | 2018-01-22 18:41:53 |
Message-ID: | 98ab66a5-b55a-1e0d-5c0a-9823dbf9c125@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 19/01/18 12:41, Marco Nenciarini wrote:
> Hi Peter,
>
> Il 18/01/18 17:30, Peter Eisentraut ha scritto:
>> On 1/17/18 11:33, Petr Jelinek wrote:
>>>> P.S: I'm struggling to understand why we have two possible values of
>>>> session_replication_role settings that behave identically (origin and
>>>> local). I'm unable to see any difference according to the code or the
>>>> documentation, so I'm wondering if we should document that they are the
>>>> same.
>>>>
>>> It's for use by 3rd party tools (afaik both londiste and slony use it)
>>> to differentiate between replicated and not replicated changes.
>>
>> I have committed some documentation updates and tests to cover this a
>> bit better.
>>
>
> Thanks, the documentation is a lot clearer now.
>
> This superseded the documentation change that was in the patch, so I've
> removed it from the v3 version.
>
Now that we have tests for this, I think it would be good idea to expand
them to cover the new behavior of TRUNCATE in this patch.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2018-01-22 18:45:50 | Re: [PATCH] Logical decoding of TRUNCATE |
Previous Message | Vik Fearing | 2018-01-22 18:41:20 | Re: PATCH: psql tab completion for SELECT |