| From: | Paul Ramsey <pramsey(at)cleverelephant(dot)ca> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [PATCH] postgres_fdw extension support |
| Date: | 2015-10-06 12:26:20 |
| Message-ID: | etPan.5613bdec.8138641.f3d@Crane.local |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On October 4, 2015 at 9:56:10 PM, Michael Paquier (michael(dot)paquier(at)gmail(dot)com(mailto:michael(dot)paquier(at)gmail(dot)com)) wrote:
> On Sun, Oct 4, 2015 at 11:40 AM, Paul Ramsey wrote:
> > I put all changes relative to your review here if you want a nice colorized
> > place to check
> >
> > https://github.com/pramsey/postgres/commit/ed33e7489601e659f436d6afda3cce28304eba50
>
> - /* updatable is available on both server and table */
> + /* updatable option is available on both server and table */
> This is just noise (perhaps I am the one who introduced it, oops).
No, I did, it matches the change to the comment below that addresses Andres note. The principle of least change is butting up against the principle of language usage consistency here. Can remove, of course.
P
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-10-06 12:32:03 | Re: [PATCH] postgres_fdw extension support |
| Previous Message | Kyotaro HORIGUCHI | 2015-10-06 11:35:06 | Re: [Proposal] Table partition + join pushdown |