| From: | "Pavlo Golub" <pavlo(dot)golub(at)cybertec(dot)at> |
|---|---|
| To: | "Christoph Berg" <myon(at)debian(dot)org> |
| Cc: | "Sami Imseih" <samimseih(at)gmail(dot)com>, "Bertrand Drouvot" <bertranddrouvot(dot)pg(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements |
| Date: | 2026-02-06 12:57:24 |
| Message-ID: | em462c0bc8-4dcd-4c36-b416-e3bc194fa770@cybertec.at |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
>Is this extra complexity worth one saved GetCurrentTimestamp()?
I'm not sure really. But I really need a new column in one way or
another, so I can agree to whatever decision we'll make.
>
>
>src/backend/access/transam/xact.c is calling GetCurrentTimestamp a
>lot already, so I don't really buy the argument it should be avoided
>at all cost in pg_stat_statements. Just storing the statement end time
>would make this use case much nicer.
+1
Maybe just move GetCurrentTimestamp outside of spin lock is engouh
already?
>
>
>Christoph
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2026-02-06 12:58:43 | Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row |
| Previous Message | Sugamoto Shinya | 2026-02-06 12:53:31 | Re: [PATCH] Add error hints for invalid COPY options |