pg_dump: Fix dangling pointer in EndCompressorZstd()

From: Alexander Kuznetsov <kuznetsovam(at)altlinux(dot)org>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: egori(at)altlinux(dot)org, nickel(at)altlinux(dot)org
Subject: pg_dump: Fix dangling pointer in EndCompressorZstd()
Date: 2025-04-16 08:27:37
Message-ID: efaee52b-9550-44ca-8633-ea86076b3283@altlinux.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello everyone,

We've found that EndCompressorZstd() doesn't set cs->private_data to NULL after pg_free(),
unlike other EndCompressor implementations.
While this doesn't currently cause issues (as the pointer soon gets reassigned),
we recommend fixing this to maintain consistency with other implementations and prevent potential future issues.

The patch is attached, would appreciate your thoughts on this change.

--
Best regards,
Alexander Kuznetsov

Attachment Content-Type Size
0001-pg_dump-Fix-dangling-pointer-in-EndCompressorZstd.patch text/x-patch 1.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jakub Wartak 2025-04-16 09:14:32 NUMA shared memory interleaving
Previous Message Hayato Kuroda (Fujitsu) 2025-04-16 08:12:33 RE: recoveryCheck test failure on flaviventris