| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Subject: | Re: logical replication busy-waiting on a lock |
| Date: | 2017-06-09 01:20:03 |
| Message-ID: | ef55d5c2-50d9-8f31-2a07-8d85366c9854@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09/06/17 01:06, Andres Freund wrote:
> Hi,
>
> On 2017-06-03 04:50:00 +0200, Petr Jelinek wrote:
>> One thing I don't like is the GetLastLocalTransactionId() that I had to
>> add because we clear the proc->lxid before we get to AtEOXact_Snapshot()
>> but I don't have better solution there.
>
> I dislike that quite a bit - how about we instead just change the
> information we keep in exportedSnapshots? I.e. store a pointer to an
> struct ExportedSnapshot
> {
> char *exportedAs;
> Snapshot snapshot;
> }
>
> Then we can get rid of that relatively ugly list_length() business too.
>
That sounds reasonable, I'll do that.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2017-06-09 01:58:19 | Fix comment in shm_mq.c |
| Previous Message | Petr Jelinek | 2017-06-09 01:16:59 | Re: walsender termination error messages worse in v10 |