| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <tmunro(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Prefetch data referenced by the WAL, take II. |
| Date: | 2022-04-07 12:18:05 |
| Message-ID: | ef12f73f-3d85-75bf-6728-6f03b77c8d61@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 4/7/22 04:36, Andres Freund wrote:
> Hi,
>
> On 2022-04-07 07:44:20 +0000, Thomas Munro wrote:
>> Prefetch data referenced by the WAL, take II.
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-04-07%2008%3A17%3A27
> thinks that xlogpretcher.h doesn't include enough...
>
> I had added those checks to CI, but apparently somehow screwed that up.
>
> Or maybe it's the scripts that are screwed up? Because I don't see any error
> checking in headerscheck/cpluspluscheck. And indeed, locally they show the
> errors, but exit with 0.
Yeah, you can't rely on the exit status, if they produce output that
should be regarded as a failure (that's what crake does).
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-04-07 13:53:43 | Re: pgsql: Prefetch data referenced by the WAL, take II. |
| Previous Message | Daniel Gustafsson | 2022-04-07 12:04:11 | pgsql: Fix typo in xlogrecovery.c code comment |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2022-04-07 12:36:28 | Re: How about a psql backslash command to show GUCs? |
| Previous Message | Daniel Gustafsson | 2022-04-07 12:04:45 | Re: Fix a typo in xlogrecovery.c |