| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | James Hilliard <james(dot)hilliard1(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX. |
| Date: | 2021-03-29 13:52:10 |
| Message-ID: | ef0dbb86-511d-94a0-de54-ce526c505a4a@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi James,
On 1/31/21 1:59 AM, James Hilliard wrote:
> On Fri, Jan 22, 2021 at 12:32 PM James Hilliard
> <james(dot)hilliard1(at)gmail(dot)com> wrote:
>>
>> Fixes:
>> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -O2 -I../../../../src/include -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -c -o fd.o fd.c
>> fd.c:3661:10: warning: 'pwritev' is only available on macOS 11.0 or newer [-Wunguarded-availability-new]
>> part = pg_pwritev(fd, iov, iovcnt, offset);
>> ^~~~~~~~~~
It would be better to provide this patch as an attachment so the cfbot
(http://commitfest.cputube.org/) can test it.
Regards,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arne Roland | 2021-03-29 14:02:35 | Re: Rename of triggers for partitioned tables |
| Previous Message | vignesh C | 2021-03-29 13:37:58 | Re: [PATCH] Provide more information to filter_prepare |