From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Subject: | Fix inconsistencies for v12 |
Date: | 2019-05-25 20:50:09 |
Message-ID: | ef0c0232-0c1d-3a35-63d4-0ebd06e31387@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello hackers,
Please also consider fixing the following inconsistencies found in new
v12 code:
1. AT_AddOids - remove (orphaned after 578b2297)
2. BeingModified ->TM_BeingModified (for consistency)
3. copy_relation_data -> remove (orphaned after d25f5191)
4. endblock -> endblk (an internal inconsistency)
5. ExecContextForcesOids - not changed, but may be should be removed
(orphaned after 578b2297)
6. ExecGetResultSlot - remove (not used since introduction in 1a0586de)
7. existedConstraints & partConstraint -> provenConstraint &
testConstraint (sync with implementation)
8. heap_parallelscan_initialize -> remove the sentence (changed in c2fe139c)
9. heap_rescan_set_params - remove (orphaned after c2fe139c)
10. HeapTupleSatisfiesSnapshot -> HeapTupleSatisfiesVisibility (an
internal inconsistency)
11. interpretOidsOption - remove (orphaned after 578b2297)
12. item_itemno -> iter_itemno (an internal inconsistency)
13. iterset_is_member -> intset_is_member (an internal inconsistency)
14. latestRemovedxids -> latestRemovedXids (an inconsistent case)
15. newrode -> newrnode (an internal inconsistency)
16. NextSampletuple -> NextSampleTuple (an inconsistent case)
17. oid_typioparam - remove? (orphaned after 578b2297)
18. recoveryTargetIsLatest - remove (orphaned after 2dedf4d9)
19. register_unlink -> register_unlink_segment (an internal inconsistency)
20. RelationGetOidIndex ? just to remove the paragraph (orphaned after
578b2297)
21. slot_getsomeattr -> checked in slot_getsomeattrs ? (an internal
inconsistency and questionable grammar)
22. spekToken -> specToken (an internal inconsistency)
23. SSLdone -> secure_done (sync with implementation)
24. stats_relation & keep_buf - remove (orphaned after 9a8ee1dc & 5db6df0c0)
25. SyncRequstHandler -> SyncRequestHandler (a typo)
26. table_needs_toast_table -> table_relation_needs_toast_table (an
internal inconsistency)
27. XactTopTransactionId -> XactTopFullTransactionId (an internal
inconsistency)
The separate patches for all the defects (except 5) are attached. In
case a single patch is preferable, I can produce it too.
Best regards,
Alexander
Attachment | Content-Type | Size |
---|---|---|
AT_AddOids.patch | text/x-patch | 656 bytes |
BeingModified.patch | text/x-patch | 447 bytes |
copy_relation_data.patch | text/x-patch | 951 bytes |
endblock.patch | text/x-patch | 592 bytes |
ExecGetResultSlot.patch | text/x-patch | 638 bytes |
existedConstraints.patch | text/x-patch | 806 bytes |
heap_parallelscan_initialize.patch | text/x-patch | 715 bytes |
heap_rescan_set_params.patch | text/x-patch | 784 bytes |
HeapTupleSatisfiesSnapshot.patch | text/x-patch | 700 bytes |
interpretOidsOption.patch | text/x-patch | 681 bytes |
item_itemno.patch | text/x-patch | 611 bytes |
iterset_is_member.patch | text/x-patch | 525 bytes |
latestRemovedxids.patch | text/x-patch | 536 bytes |
newrode.patch | text/x-patch | 499 bytes |
NextSampletuple.patch | text/x-patch | 607 bytes |
oid_typioparam.patch | text/x-patch | 509 bytes |
recoveryTargetIsLatest.patch | text/x-patch | 649 bytes |
register_unlink.patch | text/x-patch | 539 bytes |
RelationGetOidIndex.patch | text/x-patch | 844 bytes |
slot_getsomeattr.patch | text/x-patch | 541 bytes |
spekToken.patch | text/x-patch | 600 bytes |
SSLdone.patch | text/x-patch | 722 bytes |
stats_relation.patch | text/x-patch | 1.0 KB |
SyncRequstHandler.patch | text/x-patch | 468 bytes |
table_needs_toast_table.patch | text/x-patch | 487 bytes |
XactTopTransactionId.patch | text/x-patch | 791 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2019-05-25 23:00:41 | Re: Cleaning up and speeding up string functions |
Previous Message | Tom Lane | 2019-05-25 16:50:42 | Re: Cleaning up and speeding up string functions |