| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Cleaning up threading code |
| Date: | 2023-07-03 07:29:34 |
| Message-ID: | ee52b872-bcc7-a181-c537-2dc6662308da@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10.06.23 07:26, Andres Freund wrote:
>> -###############################################################
>> -# Threading
>> -###############################################################
>> -
>> -# XXX: About to rely on thread safety in the autoconf build, so not worth
>> -# implementing a fallback.
>> -cdata.set('ENABLE_THREAD_SAFETY', 1)
>
> I wonder if we should just unconditionally set that in c.h or such? It'd not
> be crazy for external projects to rely on that being set.
We definitely should keep the mention in ecpg_config.h.in, since that is
explicitly put there for client code to use. We keep HAVE_LONG_LONG_INT
etc. there for similar reasons.
Another comment on patch 0003: I think this removal in configure.ac is
too much:
- else
- LDAP_LIBS_FE="-lldap $EXTRA_LDAP_LIBS"
This could would still be reachable for $enable_thread_safety=yes and
$thread_safe_libldap=yes, which I suppose is the normal case?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-07-03 07:30:26 | Re: Add information about command path and version of flex in meson output |
| Previous Message | Fabien COELHO | 2023-07-03 07:24:17 | Re: pgbench: option delaying queries till connections establishment? |