Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors

From: Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>, Teodor Sigaev <teodor(at)sigaev(dot)ru>
Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
Date: 2018-06-09 21:38:55
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 09-06-2018 16:31, Fabien COELHO wrote:
> Hello Marina,


>> v9-0002-Pgbench-errors-use-the-Variables-structure-for-cl.patch
>> - a patch for the Variables structure (this is used to reset client
>> variables during the repeating of transactions after
>> serialization/deadlock failures).
> About this second patch:
> This extracts the variable holding structure, so that it is somehow
> easier to reset them to their initial state on transaction failures,
> the management of which is the ultimate aim of this patch series.
> It is also cleaner this way.
> Patch applies cleanly on top of the previous one (there is no real
> interactions with it). It compiles cleanly. Global & pgbench "make
> check" are both ok.


> The structure typedef does not need a name. "typedef struct { } V...".


> I tend to disagree with naming things after their type, eg "array".
> I'd suggest "vars" instead. "nvariables" could be "nvars" for
> consistency with that and "vars_sorted", and because
> "foo.variables->nvariables" starts looking heavy.
> I'd suggest but "Variables" type declaration just after "Variable"
> type declaration in the file.

Thank you, I agree and I'll fix all this.

Marina Polyakova
Postgres Professional:
The Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2018-06-09 21:48:21 Re: Add
Previous Message Marina Polyakova 2018-06-09 21:27:02 Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors