| From: | Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | itsajin(at)gmail(dot)com, amit(dot)kapila16(at)gmail(dot)com |
| Subject: | [PATCH] Provide more information to filter_prepare |
| Date: | 2021-03-09 08:44:40 |
| Message-ID: | ee280000-7355-c4dc-e47b-2436e7be959c@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
currently, only the gid is passed on to the filter_prepare callback.
While we probably should not pass a full ReorderBufferTXN (as we do for
most other output plugin callbacks), a bit more information would be
nice, I think.
Attached is a patch that adds the xid (still lacking docs changes). The
question about stream_prepare being optional made me think about whether
an output plugin needs to know if changes have been already streamed
prior to a prepare. Maybe not? Any other information you think the
output plugin might find useful to decide whether or not to skip the
prepare?
If you are okay with adding just the xid, I'll add docs changes to the
patch provided.
Regards
Markus
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-add-xid-arg-to-filter_prepare_v1.patch | text/x-patch | 6.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2021-03-09 08:51:29 | Re: About to add WAL write/fsync statistics to pg_stat_wal view |
| Previous Message | Amit Kapila | 2021-03-09 08:39:43 | Re: Make stream_prepare an optional callback |