Re: Remove Deprecated Exclusive Backup Mode

From: David Steele <david(at)pgmasters(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove Deprecated Exclusive Backup Mode
Date: 2020-07-01 20:34:21
Message-ID: eda5fa5e-0186-c347-a40d-1939f9bbe9f9@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/1/20 4:27 PM, David Steele wrote:
>
> Here's a thought. What if we just stored the oldest starting LSN and a
> count of how many backups have been requested. When the backup ends it
> checks that backup count is > 0 and starting LSN is <= its starting LSN.
> If not, it throws an error. When backups go to 0 FPWs are turned off if
> they were off before the first backup.

To be clear, the min starting LSN only needs to be reset when
incrementing total running backups from 0 to 1. What we are recording
here is the LSN since FPWs were enabled. As long as it is <= the start
LSN of the backup when it ends then all is well (I think).

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2020-07-01 20:36:03 Re: Remove Deprecated Exclusive Backup Mode
Previous Message Pavel Stehule 2020-07-01 20:34:18 Re: SQL-standard function body