Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

On 18.06.25 07:49, Peter Smith wrote:
>>> I'm also suggesting that "clean" or "cleanup" may be even better than
>>> "drop". Because if you look at related tools such as pg_basebackup,
>>> pg_receivewal, etc., the "create" and "drop" actions all happen on the
>>> remote instance, but what we are talking about here happens on the local
>>> (new) instance, so a slightly different term from those might be
>>> appropriate. Moreover, "clean(up)" has a connotation "don't need it
>>> anymore", which is fitting for this.
>>>
>>
>> I am fine with changing the name to "clean" or "cleanup" as it has
>> some precedence as well but would like to see if Peter or David has
>> any opinion on this, as they were previously involved in naming this
>> option.
>>
>
> My original comment was only considering the resulting action so at
> the time I felt "cleaning" publications made less sense to me than
> just saying what was really happening ("dropping" the publications).
>
> But I was not taking into account any precedent from other command
> option names. So if "clean" is already a precedent, then I am fine
> with calling this option clean too.

Here is a patch with a straight rename from --remove to --clean,
dropping the short option. I'm not planning to do anything about the
argument format.