Re: [PATCH] Cleanup of GUC units code

From: "Asko Oja" <ascoja(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Gregory Stark" <stark(at)enterprisedb(dot)com>, "Marko Kreen" <markokr(at)gmail(dot)com>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Cleanup of GUC units code
Date: 2008-09-02 21:42:43
Message-ID: ecd779860809021442g296eecdapbc136f7918ccf863@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Anything that will reduce potential downtime should be way to go.
To me it seems that Peter uses the loudest voice and others just don't care
enough.
Using kB for kilobyte seems quite alien and confusing. I have not noticed
that to be used in software i use in my everyday work and could not find any
either with quick search.

On Wed, Sep 3, 2008 at 12:15 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> > "Marko Kreen" <markokr(at)gmail(dot)com> writes:
> >> Uh. So you want force "proper" units in presentations at the price
> >> of everyday admin operations? Does not seem like a sensible tradeoff.
>
> > It didn't to anyone else when Peter wrote the current version either, but
> as
> > the person willing to actually do the work and write the code Peter got
> to
> > make the decision. Nobody else stepped up to do the work to change it and
> we
> > can't exactly force Peter to do work he doesn't agree with.
>
> It's not that, in my mind: it's that Peter feels more strongly about it
> than the rest of us. This proposal has come up before and he's
> successfully argued it down each time. He does have a point about there
> being some potential for confusion; and the arguments on the other side
> are not much better than "I'm lazy". Being lazy myself, I'd prefer a
> case insensitive implementation; but I don't feel strongly enough about
> it to want to override Peter's opinion.
>
> regards, tom lane
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Brian Hurt 2008-09-02 21:47:49 Feature request: better debug messages
Previous Message Tom Lane 2008-09-02 21:15:10 Re: [PATCH] Cleanup of GUC units code