Re: pg_stat_statements and "IN" conditions

From: David Steele <david(at)pgmasters(dot)net>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <stark(at)mit(dot)edu>, Pavel Trukhanov <pavel(dot)trukhanov(at)gmail(dot)com>
Subject: Re: pg_stat_statements and "IN" conditions
Date: 2021-03-18 13:38:09
Message-ID: ec47aa60-0a7b-ea3a-222a-5c6a754c2def@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/5/21 10:51 AM, Zhihong Yu wrote:
>
> +   int         lastExprLenght = 0;
>
> Did you mean to name the variable lastExprLenghth ?
>
> w.r.t. extracting to helper method, the second and third
> if (currentExprIdx == pgss_merge_threshold - 1) blocks are similar.
> It is up to you whether to create the helper method.
> I am fine with the current formation.

Dmitry, thoughts on this review?

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Surafel Temesgen 2021-03-18 13:40:43 Re: Calendar support in localization
Previous Message Ibrar Ahmed 2021-03-18 13:37:41 Re: should INSERT SELECT use a BulkInsertState?