Re: Add a test for "cannot truncate foreign table"

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add a test for "cannot truncate foreign table"
Date: 2022-07-07 15:25:24
Message-ID: ebfc16eb-10b5-30b3-152f-f58bedbf5a94@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022/06/30 10:48, Yugo NAGATA wrote:
> Hello,
>
> During checking regression tests of TRUNCATE on foreign
> tables for other patch [1], I found that there is no test
> for foreign tables that don't support TRUNCATE.
>
> When a foreign table has handler but doesn't support TRUNCATE,
> an error "cannot truncate foreign table xxx" occurs. So, what
> about adding a test this message output? We can add this test
> for file_fdw because it is one of the such foreign data wrappers.
>
> I attached a patch.

Thanks for the patch! It looks good to me.
I changed the status of this patch to ready-for-committer,
and will commit it barring any objeciton.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-07-07 15:33:00 Re: Add a test for "cannot truncate foreign table"
Previous Message Tom Lane 2022-07-07 15:25:19 Re: Use outerPlanState macro instead of referring to leffttree