| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: contrib modules and relkind check |
| Date: | 2017-03-08 08:10:21 |
| Message-ID: | eb231119-1f0c-0783-7312-2c30e0faf240@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/03/08 16:47, Michael Paquier wrote:
> On Tue, Mar 7, 2017 at 4:15 PM, Amit Langote wrote:
> +++ b/contrib/pg_visibility/expected/pg_visibility.out
> @@ -0,0 +1,85 @@
> +CREATE EXTENSION pg_visibility;
> +--
> +-- check that using the module's functions with unsupported relations will fail
> +--
> [...]
> +select count(*) > 0 from pg_visibility('regular_table');
> + ?column?
> +----------
> + t
> +(1 row)
> Only regular tables are tested as valid objects. Testing toast tables
> is not worth the complication. Could you add as well a matview?
Done in the attached updated patch.
>
> Except for this small issue the patch looks good to me.
Thanks.
Regards,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-relkind-checks-to-certain-contrib-modules.patch | text/x-diff | 20.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-03-08 08:55:08 | Removing #include "postgres.h" from a couple of headers |
| Previous Message | Michael Paquier | 2017-03-08 07:47:26 | Re: contrib modules and relkind check |