initdb w/ restart

From: Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: initdb w/ restart
Date: 2017-09-28 19:40:35
Message-ID: eb17f132-ec23-97d6-bb2b-48bb5b123671@redhat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

In a case of

initdb /tmp/pgsql

followed by

pg_ctl -D /tmp/pgsql/ -l /tmp/logfile restart

you'll get

pg_ctl: PID file "/tmp/pgsql/postmaster.pid" does not exist
Is server running?
starting server anyway
pg_ctl: could not read file "/tmp/pgsql/postmaster.opts"

The attached patch changes the message to "trying to start server
anyway" to highlight it is an attempt, not something that will happen.

Probably not a good idea to change the logic around pg_ctl.c:688, hence
this suggestion.

Thoughts ?

Best regards,
Jesper

Attachment Content-Type Size
0001-Change-message-for-restarting-a-server-from-a-direct.patch text/x-patch 930 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message chenhj 2017-09-28 19:52:43 Re: [PATCH]make pg_rewind to not copy useless WAL files
Previous Message Fabien COELHO 2017-09-28 19:33:18 Re: pgbench stuck with 100% cpu usage