Re: make tsearch use the database default locale

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: make tsearch use the database default locale
Date: 2025-10-15 20:43:58
Message-ID: eb0a6586187fdc0b2449fdccded46ccc52d08bef.camel@j-davis.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 2025-10-07 at 15:49 -0700, Jeff Davis wrote:
> This patch series allows tsearch to use the database default locale
> for
> parsing. If the database collation is libc, there's no change.

I committed a couple of the refactoring patches and rebased. v3
attached.

v3-0003 which eliminates the "wstr" logic and uses only the "pgwstr". I
was a bit confused why both were needed, as the purpose of pg_wchar is
to abstract away the problems with wchar_t. Perhaps it's historical, or
perhaps I missed something.

Regarding the risk of behavior changes: this affects parsing the
values, but not the interpretation of values after parsing, so the risk
of index inconsistencies seems low. There's risk that a document parsed
in the old version would be parsed differently in the new version,
though. Overall, it seems comparable to the risk of fb1a18810f.

Regards,
Jeff Davis

Attachment Content-Type Size
v3-0001-Add-pg_iswxdigit-useful-for-tsearch.patch text/x-patch 5.9 KB
v3-0002-Add-pg_database_locale-to-retrieve-database-defau.patch text/x-patch 1.4 KB
v3-0003-tsearch-use-database-default-collation-for-parsin.patch text/x-patch 7.1 KB
v3-0004-Remove-obsolete-global-database_ctype_is_c.patch text/x-patch 2.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2025-10-15 20:56:55 Re: Checkpointer write combining
Previous Message Joel Jacobson 2025-10-15 20:39:14 Re: Optimize LISTEN/NOTIFY