From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Coverage improvements of src/bin/pg_basebackup and pg_receivewal --endpos |
Date: | 2017-09-12 12:19:07 |
Message-ID: | eaf29163-200e-beff-10a2-c702fe0244e3@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 9/11/17 18:21, Michael Paquier wrote:
> On Tue, Sep 12, 2017 at 5:57 AM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> I have committed this patch, after a perltidy run, but the way the libz
>> detection was implemented was a bit too hackish for me, so I have
>> omitted that for now.
>
> Thanks.
>
>> I think a more robust way would be to parse
>> Makefile.global, perhaps by a function in TestLib, so it can be reused
>> in other tests. (Even more robust would be to write out an actual Perl
>> file with configuration information somewhere, but maybe we don't need
>> to go there yet.) Or maybe have the respective make variables exported
>> when make check is called (could be included in the prove_check
>> variable?). Anyway, some more pondering could lead to a more general
>> solution.
>
> There is always room for improvement,
I interpret that as that you are not working on that right now, so I've
closed this patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tatsuro Yamada | 2017-09-12 12:20:41 | Re: CLUSTER command progress monitor |
Previous Message | Amit Khandekar | 2017-09-12 12:17:18 | Re: why not parallel seq scan for slow functions |