| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: making pg_regress less noisy by removing boilerplate |
| Date: | 2022-02-23 15:54:15 |
| Message-ID: | ea8ee6ee-cc8c-cb99-e6ae-a2c0e9176afb@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/22/22 17:06, Andres Freund wrote:
>> What's involved in moving to require Unix socket support?
> It works today (the CI scripts use it on windows for example).
>
> But it's awkward because make_temp_sockdir() defaults to /tmp/ if TMPDIR isn't
> set. Which it is not by default on windows. There's PG_REGRESS_SOCK_DIR, which
> kind of works for the msvc build, because pg_regress tests aren't run
> concurrently (whereas tap tests can be run concurrently with
> PROVE_FLAGS-j).
>
> I think we just make make_temp_sockdir() a tad smarter. Perhaps by lifting the
> code in src/bin/psql/command.c:do_edit() to src/port/path.c or such?
>
+1 for doing that.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Wong | 2022-02-23 15:58:53 | Re: Time to drop plpython2? |
| Previous Message | Tom Lane | 2022-02-23 15:30:02 | Re: Frontend error logging style |